Fix/disallow attach inline datum #325
Merged
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Codecov ReportAll modified and coverable lines are covered by tests ✅
❗ Your organization needs to install the Codecov GitHub app to enable full functionality. Additional details and impacted files@@ Coverage Diff @@
## main #325 +/- ##
==========================================
+ Coverage 83.42% 83.50% +0.08%
==========================================
Files 29 29
Lines 3705 3699 -6
Branches 929 926 -3
==========================================
- Hits 3091 3089 -2
+ Misses 448 445 -3
+ Partials 166 165 -1 ☔ View full report in Codecov by Sentry. |
|
Looks like an integration test failed due to this change. It turns out the datum from utxo is a datum hash, instead of the actual datum. I think we should allow datum to be attached if its hash was attached to an output. Something like this: if datum is not None and utxo.output.datum_hash is None and utxo.output.datum is not None: |
cffls
approved these changes
Mar 4, 2024
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
fixes #324